Fix test that creates orphan process #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test_start_runserver_with_multi_app_modules
Cycloctane
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #711 +/- ##
=======================================
Coverage 95.85% 95.85%
=======================================
Files 23 23
Lines 1712 1714 +2
Branches 198 198
=======================================
+ Hits 1641 1643 +2
Misses 46 46
Partials 25 25 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Test
test_start_runserver_with_multi_app_modulesdoesn't do cleanup after spawning dev server subprocess. This creates orphan processes after running the test.It may not be a problem in environments like container or ci action, but I think it would be better to fix this issue. I figured out the issue after seeing several unknown python processes running in background for weeks on my linux box...
Are there changes in behavior for the user?
Related issue number
Checklist